Simplify quadilateral_area + better doc #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 15.42% 15.42%
=======================================
Files 2 2
Lines 428 428
=======================================
Hits 66 66
Misses 362 362
☔ View full report in Codecov by Sentry. |
|
Looks good thanks Navid! Yeah this function is one I borrowed and was really opaque earlier |
ashjbarnes
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed to human numbering 1, 2, 3,...
I think the formula
a1 + a2 + a3 + a4 is exactso no need to update that. I did update the docs a bit to be truthful to whatquadrilateral_areadoes. Have a look @ashjbarnes, thanks!