Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change hh5 -> ik11 #468

Merged
merged 7 commits into from
Nov 27, 2024
Merged

change hh5 -> ik11 #468

merged 7 commits into from
Nov 27, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Nov 24, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anton-seaice
Copy link
Collaborator

geolon_c and geolat_c are already loaded in the fifth cell, can we load these other grid vars from the intake catalog ?

@navidcy
Copy link
Collaborator Author

navidcy commented Nov 24, 2024

We should. Feel free to edit the PR please?

@anton-seaice
Copy link
Collaborator

Ok done. I tidied up some of the plotting and ran black, so it looks like a big change, but nothing substantial actually changes.

@navidcy
Copy link
Collaborator Author

navidcy commented Nov 27, 2024

I approve; but I can't approve formally because I opened the PR.
@anton-seaice if you are happy merge?

@anton-seaice anton-seaice merged commit c1f3764 into main Nov 27, 2024
3 checks passed
@anton-seaice anton-seaice deleted the ncc/use-ik11 branch November 27, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants