Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow salt_flux_added to be used by generic tracers #196

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dougiesquire
Copy link
Collaborator

We've recently suggested changes to NOAA-GFDL/ocean_BGC generic_tracers to provide a way to pass the salt restoring/correction applied by the ocean model to generic tracers. Those proposed changes add a new subroutine generic_tracer::generic_tracer_update_from_coupler that receives the salt flux and passes it on the generic tracer's update_from_coupler routine if it is needed. Currently this feature is only utilised by the WOMBAT generic tracers which exist in the ACCESS-NRI fork of NOAA-GFDL/ocean_BGC.

To use this feature requires corresponding changes to the calling ocean model. In MOM6, the changes are as follows

  • accumulate the added salt flux in MOM_forcing_type::fluxes_accumulate
  • pass the accumulated flux to the new generic_tracer::generic_tracer_coupler_accumulate routine at the start of MOM_generic_tracer::MOM_generic_tracer_column_physics.

This PR implements these changes in ACCESS-OM3 via patches.

Note, it would be good in the long run to have these changes included in the authoritative MOM6. However, this should only happen if/when generic_tracer::generic_tracer_update_from_coupler is available in NOAA-GFDL/ocean_BGC.

@dougiesquire dougiesquire changed the title Allow fluxes%salt_flux_added to be used by generic tracers Allow salt_flux_added to be used by generic tracers Jul 29, 2024
Copy link
Contributor

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment for the salt flux due to restoring or flux adjustment. Everythiing else looks good to me.

MOM6/patches/MOM_forcing_type.F90.patch Show resolved Hide resolved
Copy link
Contributor

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear to me! Thanks!

@dougiesquire dougiesquire merged commit 63ed4a4 into main Jul 29, 2024
2 checks passed
@dougiesquire dougiesquire deleted the dougiesquire/gtracer-vstf branch July 29, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants