Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qc/web/ip address revamp #433

Merged
merged 11 commits into from
Oct 21, 2024
Merged

Qc/web/ip address revamp #433

merged 11 commits into from
Oct 21, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Oct 21, 2024

Description

This pr introduces some minor fixes and updates.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature type: fix Introduces a fix for a previous issue For: frontend This is mainly related to frontend UI code priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed effort: 2 This can be/was resolved in minutes but requires/required shallow engagement platform: web/desktop This is related to web/desktop platforms labels Oct 21, 2024
@waveyboym waveyboym added this to the PROJECT DAY🎉🎨 milestone Oct 21, 2024
@waveyboym waveyboym self-assigned this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.33%. Comparing base (2ec3c67) to head (fde2487).
Report is 38 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (2ec3c67) and HEAD (fde2487). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2ec3c67) HEAD (fde2487)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #433       +/-   ##
============================================
- Coverage    87.18%   33.33%   -53.85%     
============================================
  Files           23        1       -22     
  Lines         5461        6     -5455     
  Branches       126        0      -126     
============================================
- Hits          4761        2     -4759     
+ Misses         598        4      -594     
+ Partials       102        0      -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 0a462bf into develop Oct 21, 2024
7 of 8 checks passed
@waveyboym waveyboym deleted the QC/web/ip-address-revamp branch October 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 This can be/was resolved in minutes but requires/required shallow engagement For: frontend This is mainly related to frontend UI code platform: web/desktop This is related to web/desktop platforms priority: medium This does/did not need to be addressed soon but should have plans in place to be addressed type: feature A new feature type: fix Introduces a fix for a previous issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant