-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qc/web/ip address revamp #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing changes downstream
…estimate IP based on selected location
…SE-2024/occupi into QC/web/ip-address-revamp
…axios for IP estimation
…axios for IP estimation
waveyboym
added
type: feature
A new feature
type: fix
Introduces a fix for a previous issue
For: frontend
This is mainly related to frontend UI code
priority: medium
This does/did not need to be addressed soon but should have plans in place to be addressed
effort: 2
This can be/was resolved in minutes but requires/required shallow engagement
platform: web/desktop
This is related to web/desktop platforms
labels
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #433 +/- ##
============================================
- Coverage 87.18% 33.33% -53.85%
============================================
Files 23 1 -22
Lines 5461 6 -5455
Branches 126 0 -126
============================================
- Hits 4761 2 -4759
+ Misses 598 4 -594
+ Partials 102 0 -102 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort: 2
This can be/was resolved in minutes but requires/required shallow engagement
For: frontend
This is mainly related to frontend UI code
platform: web/desktop
This is related to web/desktop platforms
priority: medium
This does/did not need to be addressed soon but should have plans in place to be addressed
type: feature
A new feature
type: fix
Introduces a fix for a previous issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces some minor fixes and updates.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
N/A
Checklist: