Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qc/web/rooms page #429

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Qc/web/rooms page #429

merged 8 commits into from
Oct 21, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Oct 20, 2024

Description

This pr introduces some minor acceptable styling changes to the rooms page

Fixes # (issue)
#421

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: chore Just a cleanup or minor update type: feature A new feature type: fix Introduces a fix for a previous issue For: frontend This is mainly related to frontend UI code priority: high This needs/needed to be addressed as soon as possible effort: 3 This can be/was resolved in minutes be requires/required deep engagement type: task Task request platform: web/desktop This is related to web/desktop platforms For: integration This is for work involving integration with the backend/model API labels Oct 20, 2024
@waveyboym waveyboym added this to the PROJECT DAY🎉🎨 milestone Oct 20, 2024
@waveyboym waveyboym self-assigned this Oct 20, 2024
@waveyboym waveyboym linked an issue Oct 20, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.33%. Comparing base (0a462bf) to head (c635103).
Report is 9 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (0a462bf) and HEAD (c635103). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (0a462bf) HEAD (c635103)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #429       +/-   ##
============================================
- Coverage    87.18%   33.33%   -53.85%     
============================================
  Files           23        1       -22     
  Lines         5461        6     -5455     
  Branches       126        0      -126     
============================================
- Hits          4761        2     -4759     
+ Misses         598        4      -594     
+ Partials       102        0      -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 836c5a8 into develop Oct 21, 2024
7 of 8 checks passed
@waveyboym waveyboym deleted the QC/web/rooms-page branch October 21, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 3 This can be/was resolved in minutes be requires/required deep engagement For: frontend This is mainly related to frontend UI code For: integration This is for work involving integration with the backend/model API platform: web/desktop This is related to web/desktop platforms priority: high This needs/needed to be addressed as soon as possible type: chore Just a cleanup or minor update type: feature A new feature type: fix Introduces a fix for a previous issue type: task Task request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Styling fixes for rooms page for web
1 participant