Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Very many redirect problems #574

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Very many redirect problems #574

merged 1 commit into from
Oct 24, 2024

Conversation

vfeistel
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.40%. Comparing base (488f030) to head (5b10100).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (488f030) and HEAD (5b10100). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (488f030) HEAD (5b10100)
4 2
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #574       +/-   ##
============================================
- Coverage   100.00%   38.40%   -61.60%     
============================================
  Files            1       41       +40     
  Lines           22     3273     +3251     
  Branches         0       22       +22     
============================================
+ Hits            22     1257     +1235     
- Misses           0     1915     +1915     
- Partials         0      101      +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichaelHorwitz MichaelHorwitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I were to take a gander upon your code and think to myself about the quality therein I think the conclusion that would come to fruition is that it "Looks good to me" or in a more succinct manner, lgtm

@vfeistel vfeistel merged commit 85efc34 into main Oct 24, 2024
9 checks passed
@vfeistel vfeistel deleted the hotfix/signup-redirect branch October 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants