Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete sap flow sensors (quick fix) #35

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Jun 7, 2024

We can come up with a permanent fix for this later, but since the TEMPEST flood is next week, I just added a line of code to drop the sensors that no longer exist (SD2, CD6, SD9, CD10). See #32

@bpbond
Copy link
Member Author

bpbond commented Jun 7, 2024

Hmm rather than worry about updating the test snapshot each time, I'm going to do it at the end of our updates if that's okay @stephpenn1 .

So for our PRs, make sure the test error is something like

── Failed tests ────────────────────────────────────────────────────────────────
Failure (test-shinytest2.R:8:3): {shinytest2} recording: TEMPESTdash
Snapshot of `file` to 'shinytest2/TEMPESTdash-001.json' has changed

That indicates that everything loaded and ran, but the dashboard is different than the saved test image (which we'll update after our changes are in).

@bpbond bpbond requested a review from stephpenn1 June 7, 2024 16:17
@bpbond
Copy link
Member Author

bpbond commented Jun 7, 2024

Merging, assuming this approach (above) is OK with SP

@bpbond bpbond merged commit bdde9f7 into master Jun 7, 2024
1 check failed
@bpbond bpbond deleted the bye-bye-deeps branch June 7, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant