Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated Flow (static analysis tool) #33

Open
wants to merge 2 commits into
base: f24
Choose a base branch
from
Open

Integrated Flow (static analysis tool) #33

wants to merge 2 commits into from

Conversation

ericlin2
Copy link

@ericlin2 ericlin2 commented Oct 23, 2024 •
edited
Loading

Followed installation instructions via https://flow.org/en/docs/install/

Concrete evidence of installation

  • Installed necessary dependencies on npm (not shown in commit history)
  • Added .babelrc file at root
  • Added flow script to package.json

Artifacts

  • Flow detected no errors in our code, shown in screenshot below:

Screenshot 2024-10-22 at 10 52 52 PM

@ericlin2 ericlin2 changed the title Installed and ran Flow (static analysis tool) Integrated Flow (static analysis tool) Oct 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11472274244

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.666%
Totals Coverage Status
Change from base Build 11471798838: 0.0%
Covered Lines: 22323
Relevant Lines: 25583
💛 - Coveralls

@ericlin2 ericlin2 requested a review from VeronicaPim October 23, 2024 17:00
VeronicaPim
VeronicaPim reviewed Oct 23, 2024
View reviewed changes
Copy link

@VeronicaPim VeronicaPim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeronicaPim VeronicaPim VeronicaPim approved these changes

Assignees

@ericlin2 ericlin2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericlin2 @coveralls @VeronicaPim