BCDA-8124: Best practices for speeding up downloads #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dzeda
reviewed
May 14, 2024
| <p> | ||
| Requesting compressed data can help increase your download speed. You can request compressed data files by | ||
| specifying the `Accept-Encoding: gzip` header in your download requests. After you finish downloading, uncompress | ||
| (unzip) the file to access your data. |
There was a problem hiding this comment.
No need to uncompress; by specifying the header, the user's request agent should uncompress the data due to the returned Content-Encoding header. This just speeds up transport
alex-dzeda
reviewed
May 14, 2024
| @@ -170,8 +170,8 @@ <h3 class="ds-c-alert__heading"> Files expire after 24 hours.</h3> | |||
| </div> | |||
|
|
|||
| <p> | |||
| The "Accept-Encoding: gzip" header is optional, but will return a significantly smaller (40X smaller) file with a faster download speed. You will need to uncompress the file after downloading if you supply this header. When downloading multiple files, you can further speed up the process by downloading multiple files concurrently. | |||
| The "Accept-Encoding: gzip" header is optional, but will return a significantly smaller (40X smaller) file with a faster download speed. Follow our recommended best practices for <a href="#speeding-up-downloads" class="in-text__link">speeding up downloads</a>. | |||
There was a problem hiding this comment.
Can we decrease to ~30X? In tests, compression ratios are closer to 30x than 40.
alex-dzeda
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8124
🛠 Changes
ℹ️ Context for reviewers
Content drafted in BCDA-8000 and published to https://stage.bcda.cms.gov/build.html
✅ Acceptance Validation
Deployed to staging and verified links work
https://stage.bcda.cms.gov/build.html#speeding-up-downloads
https://stage.bcda.cms.gov/build.html#requesting-all-three
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.