Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-8113: Escape export operator and fix credential rendering #199

Merged
merged 4 commits into from
May 14, 2024

Conversation

alex-dzeda
Copy link
Contributor

@alex-dzeda alex-dzeda commented May 10, 2024

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8113

🛠 Changes

Ensure "Try the API" credentials show properly
Escape export operator to ensure that all environments can utilize the CURL commands.

ℹ️ Context for reviewers

When we fixed the curl commands for windows cmd, we broke it for powershell. Now, everyone can live in harmony.

✅ Acceptance Validation

image

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@alex-dzeda alex-dzeda marked this pull request as ready for review May 10, 2024 20:01
greg-pf
greg-pf previously approved these changes May 10, 2024
Copy link
Contributor

@greg-pf greg-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed I see this rendering properly on staging
image

austincanada
austincanada previously approved these changes May 10, 2024
@alex-dzeda alex-dzeda dismissed stale reviews from austincanada and greg-pf via 0d5f5b3 May 14, 2024 13:24
@alex-dzeda
Copy link
Contributor Author

image

Copy link
Contributor

@greg-pf greg-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a change from Powershell to PowerShell, otherwise looks good

@@ -11,7 +11,7 @@
All requests for BCDA data follow this four step process, as do other APIs following the Bulk FHIR specifications.
</p>
<p>
For more detail for each of these steps and specific information for retrieving production data, see the <a href=/build.html target="_self" class="in-text__link"> Building Your Application</a> page. For this short demo, follow along in your Terminal window or through an application such as Postman.
For more detail for each of these steps and specific information for retrieving production data, see the <a href=/build.html target="_self" class="in-text__link"> Building Your Application</a> page. For this short demo, follow along in your Terminal window or through an application such as Postman. Powershell users will need to replace backslash characters \ with backticks ` to properly escape the $export operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more detail for each of these steps and specific information for retrieving production data, see the <a href=/build.html target="_self" class="in-text__link"> Building Your Application</a> page. For this short demo, follow along in your Terminal window or through an application such as Postman. Powershell users will need to replace backslash characters \ with backticks ` to properly escape the $export operation.
For more detail for each of these steps and specific information for retrieving production data, see the <a href=/build.html target="_self" class="in-text__link"> Building Your Application</a> page. For this short demo, follow along in your Terminal window or through an application such as Postman. PowerShell users will need to replace backslash characters \ with backticks ` to properly escape the $export operation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@greg-pf greg-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@alex-dzeda alex-dzeda merged commit 351b677 into master May 14, 2024
1 check passed
@alex-dzeda alex-dzeda deleted the alex/static-site-updates branch May 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants