Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-7973: Add loading for Try The API creds #196

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

austincanada
Copy link
Contributor

@austincanada austincanada commented Apr 16, 2024

Add "dynamic" loading for Try The API code snippets. Puts test credentials into YML file which can be used for the rest of the codebase or other credentials.

🎫 Ticket

https://jira.cms.gov/browse/BCDA-7973

🛠 Changes

(What was added, updated, or removed in this PR.)
Added YML file to hold sandbox clients and secrets.
Updated existing usages of hard-coded clients and secrets to pull from YML file.

ℹ️ Context for reviewers

N/A

✅ Acceptance Validation

Viewed changes within local environment.
Screenshot 2024-04-18 at 3 56 26 PM
Screenshot 2024-04-18 at 3 56 36 PM
Screenshot 2024-04-18 at 3 56 47 PM
Screenshot 2024-04-18 at 3 57 00 PM
Screenshot 2024-04-18 at 3 57 11 PM

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

Add "dynamic" loading for Try The API code snippets. Puts test
credentials into YML file which can be used for the rest of the codebase
or other credentials.
Adds all of the credentials to the YML file in order to load them
dynamically.
@alex-dzeda
Copy link
Contributor

I think this will be ready to go once screenshots of the site (eg the credentials) with the changes attached (after merging changes upstream from main) are added to AC! Good job

@austincanada austincanada merged commit ff85aab into master Apr 18, 2024
1 check passed
@austincanada austincanada deleted the austin/BCDA-7973 branch April 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants