Skip to content

Refactoring Statement (Project part 5)

bkhunter edited this page Apr 7, 2015 · 14 revisions

###Refactoring Implemented since Project Part 4 Aided by the JDeodorant tool###

Ben @ 4/6/2015

  • 2 methods in TravelItineraryList numberOfDestinations() and size() returned the same value and were implemented identically. The size method was removed because it is less descriptive, and all uses of the method were replaced with numberOfDestinations().

James @ 4/6/2015

  • ExpenseListSingleton - Removed. This class was not needed
  • ExpenseAdapter - Suppress depreciated warning
  • ExpenseItemViewFragment - Removed unused imports and unused variables
  • ExpenseItemListFragment - Removed unused imports and unused variables
  • ExpenseManagerFragment - Removed unused imports
  • ManageTagsFragment - Removed unused imports
  • ExpenseItem - Removed unused imports and suppress depreciated
  • ExpenseItemList - Removed unused imports
  • Claim - Suppressed depreciated
  • Exceptions - Suppressed
  • ExpenseItemManger.xml and ExpenseViewLayout.xml - Fixed some formatting warnings
  • Tests - Removed unused imports
  • Renamed the photo activity used to receipt images

Matthew @ 4/7/2015

  • ClaimActivity - No longer uses fragments and fragment managers, it's delegated to a new class ClaimFragmentNavigator.
  • Removed all claim warnings.