Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Hsinj/clean repo #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[WIP] Hsinj/clean repo #1

wants to merge 8 commits into from

Conversation

mis0butter
Copy link

@mis0butter mis0butter commented May 26, 2023 •
edited
Loading

Cleaning up repo

Addressing comments/suggestions from meeting with @dfridovi and code review with @hmzh-khn .

Done:

  • Renamed project from GP_june to GaussianSINDy

Action items:

  • put separate configs into separate files (YAML file?)
  • put plotting stuff in separate file
  • way more unit tests
  • have helper function take in as few arguments as possible
  • testing/profiling for speed/efficiency:
    • have mini monte carlo for running code, e.g. initialize 40 time runs, average time and get variance
  • try flame graphs

Notes from code review (high level overview of algorithm):

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mis0butter