Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate earlier on failures? #7

Closed
lassepe opened this issue Nov 27, 2024 · 1 comment · Fixed by #8
Closed

Terminate earlier on failures? #7

lassepe opened this issue Nov 27, 2024 · 1 comment · Fixed by #8

Comments

@lassepe
Copy link
Contributor

lassepe commented Nov 27, 2024

A slightly modified version of the toy example in the README currently causes many linesearch-failures before the solver gives up. The underpinning problem seems to be that the inner loop breaks early and then the outer-loop concludes that the sub-problem was easy to solve, causing it to tighten \epsilon further.

Reproducer:

using MixedComplementarityProblems

M = [0 1; -1 0]
A = [1 0; 0 1]
b = [1; 1]
θ = rand(2)

G(x, y; θ) = M * x - θ - A' * y
H(x, y; θ) = A * x - b

mcp = MixedComplementarityProblems.PrimalDualMCP(
    G,
    H;
    unconstrained_dimension = size(M, 1),
    constrained_dimension = length(b),
    parameter_dimension = size(M, 1),
)
sol = MixedComplementarityProblems.solve(MixedComplementarityProblems.InteriorPoint(), mcp, θ)
@dfridovi
Copy link
Member

dfridovi commented Nov 27, 2024

@lassepe nice catch! Thoughts on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants