Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use in-place callbacks #13

Closed
lassepe opened this issue Dec 6, 2024 · 1 comment
Closed

Use in-place callbacks #13

lassepe opened this issue Dec 6, 2024 · 1 comment

Comments

@lassepe
Copy link
Contributor

lassepe commented Dec 6, 2024

Currently, the code uses the out-of-place SymbolicUtils.build_function calls which causes extra allocations. It would be a good idea to allocate a buffer and write to it very round instead to keep the GC in check

@dfridovi
Copy link
Member

dfridovi commented Dec 8, 2024

Agreed. I saw how ParametricMCPs does this, but the SparseFunction bit didn't quite make sense to me since I am not as familiar with the sparse matrix formatting details. I'd love to hop on a call and knock this out together sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants