Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile.ngen to add NGEN_WITH_SQLITE: ON #73

Closed
wants to merge 6 commits into from

Conversation

ZacharyWills
Copy link

Related to #63

For Testing gpkg support in NGIAB

Related to #63 

For Testing gpkg support in NGIAB
@ZacharyWills ZacharyWills changed the title Update Dockerfile.ngen to add NGEN_WITH_SQLITE: OFF Update Dockerfile.ngen to add NGEN_WITH_SQLITE: ON Jan 4, 2024
@ZacharyWills
Copy link
Author

Screenshot 2024-01-03 at 22 20 52

I'm making progress, just missing something somewhere

@benlee0423 benlee0423 self-requested a review January 5, 2024 16:27
@benlee0423
Copy link

@ZacharyWills
Is this working?

@arpita0911patel
Copy link
Member

I tested this PR with the image created i.e. :latest-PR tag, and it seems like not working. NGEN_WITH_SQLITE: OFF

bash-5.1# /dmod/bin/ngen --info
NGen version: 0.1.0
Build configuration summary:
Generator: Unix Makefiles
Build type:
System: Linux
C Compiler: /usr/bin/cc
CXX Compiler: /usr/bin/c++
Flags:
NGEN_WITH_MPI: ON
NGEN_WITH_NETCDF: ON
NGEN_WITH_SQLITE: OFF
NGEN_WITH_UDUNITS: ON
NGEN_WITH_BMI_FORTRAN: ON
NGEN_WITH_BMI_C: ON
NGEN_WITH_PYTHON: ON
NGEN_WITH_ROUTING: ON
NGEN_WITH_TESTS: ON
NGEN_QUIET: OFF

@arpita0911patel
Copy link
Member

According to Zach, the image works fine when built locally. Therefore, it seems that further investigation is required.

@benlee0423
Copy link

One thing I can think of is no-cache option during build.
@ZacharyWills
Can you build with no-cache=true locally and see if it produces the same error with new image built on runner?

@ZacharyWills
Copy link
Author

One thing I can think of is no-cache option during build. @ZacharyWills Can you build with no-cache=true locally and see if it produces the same error with new image built on runner?

It doesn't, when built locally with --no-cache it builds fine. It's only an issue when built by the runner.

@benlee0423
Copy link

I have removed all caches from Runner.

@arpita0911patel
Copy link
Member

arpita0911patel commented Jan 10, 2024

Ben, please let us know when you rerunun the CI against this PR. Also, please share the image name so Zach could test and make sure this PR is working.

* Run actions when PR is created and updated. (#74)

* refactor to support to run actions on pr

* add debug

* add docker token

* add input

* add env

* define env

* define env

* define env

* define env

* add secrets

* add secrets

* secrets inherit

* fix tag name

* fix tag name

* fix tag name

* set input required

* fix

* use vars

* fix variable

* remove debug

* Update HelloNGEN.sh (#75)

* Use image tag based on branch (#76)

* set tag name based on branch

* remove unused inputs

---------

Co-authored-by: ZacharyWills <[email protected]>
@benlee0423
Copy link

It is building now.
I had to merge changes in main to this branch to build.

@benlee0423
Copy link

github is not very good at diff.
Just look at Dockerfile.ngen and Dockerfile.ngen-deps for review and merge. It is safe to ignore the other files.

@benlee0423
Copy link

benlee0423 commented Jan 10, 2024

Build failed.

32.21   Could NOT find SQLite3 (missing: SQLite3_INCLUDE_DIR SQLite3_LIBRARY)
32.21 Call Stack (most recent call first):
32.21   /usr/local/lib64/python3.9/site-packages/cmake/data/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
32.21   /usr/local/lib64/python3.9/site-packages/cmake/data/share/cmake-3.28/Modules/FindSQLite3.cmake:54 (find_package_handle_standard_args)

https://github.com/CIROH-UA/NGIAB-CloudInfra/actions/runs/7479625300/job/20357925663

@benlee0423 benlee0423 changed the base branch from main to Add-gpkg-support-2 January 10, 2024 20:29
@benlee0423 benlee0423 changed the base branch from Add-gpkg-support-2 to main January 10, 2024 20:29
@benlee0423
Copy link

@arpita0911patel @ZacharyWills
DO NOT merge this PR. I messed up the files, and those are not showing diff correctly with main. I will have to create a new PR for this.
Test was successful. See my comments on the issue #63

@benlee0423 benlee0423 mentioned this pull request Jan 11, 2024
@benlee0423
Copy link

Opend #79

@arpita0911patel
Copy link
Member

Closing this one as #79 is opened for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants