run the ngen image build/test on PR's to main and pr-merge branches #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this will work. We are working on it to handle this. |
|
Care to elaborate as to why you don't think this will work? |
|
Other than the checks being "Skipped", this is getting towards the desired outcome -- running the test/workflow on PR's... 
|
|
Best practice: Here: |
|
Closing this PR as this is taken care by #74 (CI changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger ngen image build aciton on PR. This can probably be refined a little bit, but will test PR's on this repo to ensure the main ngen image builds with proposed changes.
Possibly related to #49