-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PR from forked branch #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @benlee0423 for working on these CI pipeline changes. Great work indeed!! I'm reviewing it now and will let you know if anything. Additional testing will be done once the PRs are submitted using forked branches. Also adding @hellkite500 and @ZacharyWills for final review.
Can you clarify at a high level what these workflow changes do when a PR is created? From what I can tell, these are still attempting to do a complete end-to-end build, push, test workflow for every PR, and still requires manual engagement of the runner to perform any testing of a PR from an external source? |
See updated description of this PR, and requirement section. |
No, on PR it will do build and test ( with auto-mode running with fixed input data). |
We will be using fixed source ( files on the Runner) and auto-mode running. There will be no manual engagement. |
Updated PR description for clarification. |
Merging it to test it works for the forked PRs and then if any issues we can fix it after that. |
Requirement from Issue 86:
On a pull request, the pipeline will build and run tests using the container on the runner in auto mode and sample test data. On merge to the main branch, the pipeline will build and push the Docker image to DockerHub.
What is included in this PR:
What is NOT included in this PR:
Note: PR from forked branch needs to start/stop Runner manually for security reason all time.