Kristoff

[kristoffPotgieter]

Hi i've added some amenity measures which are causing bugs. Modifications a
have been made to import_amenities.py and calib_main_function.py

[TLMonnier]

Here is my review:

• I don't know what you changed in calib_nb.ipynb, but a priori it is not needed to touch anything there
• Ok to displace the variable selection from calib_main_func.py if you prefer. Note that, in principle, the variables_regression variable should be defined as a list (not an Index)
• Nothing to declare on import_amenities.py, the bug does not come from there.

Actually, if you read the error message more carefully, you'll see that the bug does not come from calling the import_exog_amenities function to define the amenities_sp variable, but lower in the calib_main_func.py script, when defining the amenities_grid variable. The reason is simply that the file grid_amenities.csv does not exist!

Indeed, you need the data at the SP level to estimate the amenity effects (this works), but then you also need the covariates at the grid level to be able to map the amenity score at the grid level, as is done in the calib_nb.ipynb script. If you want, there's a function called gen_small_areas_to_grid in the data.py module that would allow you to do that (although I have not tested it for that purpose, so you can also do the disaggregation yourself if you prefer).