New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vignette for coding guidelines #36

Merged

ChristopherMancuso merged 1 commit into master from vin-coding

Dec 6, 2024

Collaborator

ChristopherMancuso commented Dec 6, 2024

Closes out issue #32


          added vignette for coding guidelines #32

d2b8155

ChristopherMancuso requested review from petersonR and max-mcgrath

December 6, 2024 03:50

Collaborator Author

ChristopherMancuso commented Dec 6, 2024

@max-mcgrath @petersonR If either of you want to look at this before I merge let me know. Two things

Max in your git vignette, you had a function to find png's. I just hard coded the whole figure name. Is that OK?
Not sure if the stuff at the top of the RMD is in the correct style so maybe that needs to be updated?

petersonR approved these changes

View reviewed changes

ChristopherMancuso merged commit 9b1d4c5 into master

6 checks passed

ChristopherMancuso deleted the vin-coding branch

December 6, 2024 19:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet