Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggswim Redevelopment #58

Merged
merged 23 commits into from
Sep 27, 2024
Merged

ggswim Redevelopment #58

merged 23 commits into from
Sep 27, 2024

Conversation

rsh52
Copy link
Contributor

@rsh52 rsh52 commented Sep 27, 2024

Description

This PR vastly simplifies the API for ggswim by intelligently using scales and synonymous aes techniques to handle much of what was being done with points and markers previously.

This was made possible thanks in huge part to @teunbrand and @yjunechoe and I will be sure to highlight you both for credit in this.

Proposed Changes

List changes below in bullet format:

  • Remove geom_swim_point()
  • Remove geom_swim_label()
  • Remove {ggnewscale} dependencies, remove use of ggplot_add, remove print/build/grid methods
    • The latter can be reinstated down the line if needed
  • Add geom_swim_marker()
  • Add scale_marker_discrete()
  • Update datasets
  • Update test suite
  • Update vignettes
  • Update README

@rsh52 rsh52 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 27, 2024
@rsh52 rsh52 self-assigned this Sep 27, 2024
@rsh52 rsh52 marked this pull request as ready for review September 27, 2024 21:02
@rsh52 rsh52 merged commit 8da8c9d into main Sep 27, 2024
11 checks passed
@rsh52 rsh52 deleted the redev branch September 27, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants