Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are several known errors that occur when calling
geom_swim_label()
in a few cases:new_scale_color()
and other geomsaes()
definitions within a top-levelggplot()
callProposed Changes
capture_error()
function for testing onlycapture_error()
is being used to test for equivalent errors between ggplot-vanilla and ggswim. Mostly to help keep a reference of errors that aren't introduced by us (or my fault!)try_ggswim()
so it returns original error when not a special caseget_mapping_obj()
function to capturegeom_swim_label()
mapping and correctly re-introduce inherited missing params from the current layerIssue Addressed
Closes #50
Closes #51