Fix failure when forms
is used for projects with a stand-alone record id instrument
#213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug causing
read_redcap()
to fail when:forms
is supplied and doesn't include the instrument with the record ID ANDThis scenario results in an empty
metadata
df insideget_fields_to_drop()
. The fix was including an early return if this occurs.I also did some cleanup to resolve lingering warnings when
tidyselect >=1.2.0
is installed.Proposed Changes
get_fields_to_drop()
to return early if metadata has no additional fields to droptidyselect
warningsIssue Addressed
relates to #212
PR Checklist
Before submitting this PR, please check and verify below that the submission meets the below criteria:
.RDS
) updated underinst/testdata/create_test_data.R
usethis::use_version()
Code Review
This section to be used by the reviewer and developers during Code Review after PR submission
Code Review Checklist