Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Complete Metadata Column for Supertibble #188

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

rsh52
Copy link
Collaborator

@rsh52 rsh52 commented Mar 22, 2024

Description

This is a very light PR adding in form_complete_pct as a metadata column to the supertibble. It summarizes the average of "Complete"s/2's for a given form (it does not take into account unverifieds, etc. which I don't think we can capture in one column).

Proposed Changes

List changes below in bullet format:

  • Add form_complete_pct to supertibble metadata columns
  • Update write_redcap_xlsx to appropriately handle percentage output (similar to data_na_pct)
  • Update README image to show new column.

Issue Addressed

Closes #183

PR Checklist

Before submitting this PR, please check and verify below that the submission meets the below criteria:

  • New/revised functions have associated tests
  • [NA] New/revised functions that update downstream outputs have associated static testing files (.RDS) updated under inst/testdata/create_test_data.R
  • [NA] New/revised functions use appropriate naming conventions
  • New/revised functions don't repeat code
  • Code changes are less than 250 lines total
  • Issues linked to the PR using GitHub's list of keywords
  • The appropriate reviewer is assigned to the PR
  • The appropriate developers are assigned to the PR
  • Pre-release package version incremented using usethis::use_version()

Code Review

This section to be used by the reviewer and developers during Code Review after PR submission

Code Review Checklist

  • I checked that new files follow naming conventions and are in the right place
  • I checked that documentation is complete, clear, and without typos
  • I added/edited comments to explain "why" not "how"
  • I checked that all new variable and function names follow naming conventions
  • I checked that new tests have been written for key business logic and/or bugs that this PR fixes
  • I checked that new tests address important edge cases

@rsh52 rsh52 added the enhancement New feature or request label Mar 22, 2024
@rsh52 rsh52 added this to the 1.1 milestone Mar 22, 2024
@rsh52 rsh52 self-assigned this Mar 22, 2024
@rsh52 rsh52 marked this pull request as ready for review March 22, 2024 20:13
@rsh52 rsh52 requested review from ezraporter and skadauke March 22, 2024 20:13
Copy link
Collaborator

@ezraporter ezraporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

DESCRIPTION Outdated
@@ -1,7 +1,7 @@
Package: REDCapTidieR
Type: Package
Title: Extract 'REDCap' Databases into Tidy 'Tibble's
Version: 1.1.0
Version: 1.1.0.9000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually don't want to bump this if we plan to release this as part of 1.1.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yea right. 👍

@rsh52 rsh52 merged commit 28339bb into main Mar 25, 2024
4 checks passed
@rsh52 rsh52 deleted the form_complete_pct branch March 25, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: form_complete_pct in supertibble
2 participants