-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gsoc2024 hexahedral mesh generation tbenard #8445
Draft
theo97490
wants to merge
46
commits into
CGAL:master
Choose a base branch
from
theo97490:gsoc2024-hexahedral_mesh_generation-tbenard
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Gsoc2024 hexahedral mesh generation tbenard #8445
theo97490
wants to merge
46
commits into
CGAL:master
from
theo97490:gsoc2024-hexahedral_mesh_generation-tbenard
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working example for 1/2 template substitution
* Detection of "sandwiched" volumes (that share only a edge with the plane) * Related: Traversal takes into account problematic 1/2 templates faces * Repair impossible markings (wip)
* 3 templates outside of iteration plane are not refined * Issue: I think 3 templates should be allowed outside of the plane, since we check for 3 templates validity only inside the plane * Solution: Either a propagation issue ( keep older 1/2 templates propageable ) or else its a non issue and properly detect the 3 templates outside the plane.
* WIP Expansion of initial identified set, for additional level of refinement * WIP Creation of new iteration plane for the next level. => Uses Union_find, to create connected components, for the algorithm to avoid iterating outside of the current level context ( Local rebase of 5 commits )
Force-push/edited to fix issues, WIP
Numbers vertices to biject ghosts cells between two threads. First iteration works
fix_dart_storage for ghost cells volumes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implementation of the method used in the paper "A template-based approach for parallel hexahedral two-refinement", Steven J. Owen, Ryan M. Shih, Corey D. Ernst (2015, 2017);
Adds two functions to compute the hexahedral two-refinement of a mesh under the Linear Cell Complex package, respectively a single-threaded and multi-threaded version of the algorithm.
Additionnal information on the project public gist here
We asked ourselves with gdamiand if this this going to be a package or a part of the LCC package. I think the algorithm has no real purpose to have its own package. Currently it is written as an example under the LCC package, we might move it in the end into the include folder of the package.
TODO