Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperbolic surface triangulation 2 (new package) #8259

Open
wants to merge 106 commits into
base: master
Choose a base branch
from

Conversation

loic-dubois
Copy link
Member

@loic-dubois loic-dubois commented Jun 5, 2024

Summary of Changes

This package enables building and handling triangulations of closed orientable hyperbolic surfaces: a basic tool for any future implementation of algorithms operating on such surfaces. Functionalities are offered such as the Delaunay flip algorithm, and the construction of a portion of the lift of the triangulation in the Poincaré disk model of the hyperbolic plane. Triangulations can be generated by triangulating a convex fundamental domain in the Poincaré disk. A method is offered that generates such domains in genus two.

Release Management

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature labels Jun 5, 2024
@MaelRL MaelRL added this to the 6.1-beta milestone Jun 5, 2024
@MaelRL MaelRL changed the title Hyperbolic surface triangulation 2 dubois Hyperbolic surface triangulation 2 (new package) Jun 5, 2024
@afabri
Copy link
Member

afabri commented Jun 5, 2024

/build:v0

Copy link

github-actions bot commented Jun 5, 2024

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v0/Manual/index.html

@pougetma
Copy link
Member

/build:v1

Copy link

There was an error while building the doc:

error: Tag file '/home/runner/work/cgal/cgal/build_doc/doc_tags/Algebraic_foundationsw.tag' does not exist or is not a file. Skipping it...

https://github.com/CGAL/cgal/actions/runs/11341743466

@pougetma
Copy link
Member

/build:v1

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

@pougetma
Copy link
Member

/build:v1

/// @{
/*!
represents a complex number, model of
`ComplexNumber', over the field HyperbolicSurfaceTraits_2::FT for its real and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`ComplexNumber', over the field HyperbolicSurfaceTraits_2::FT for its real and
`ComplexNumber', over the field `HyperbolicSurfaceTraits_2::FT` for its real and

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

@sloriot
Copy link
Member

sloriot commented Dec 24, 2024

Red testsuite in CGAL-6.1-Ic-47

@pougetma
Copy link
Member

pougetma commented Jan 8, 2025

/build:v1

Copy link

github-actions bot commented Jan 8, 2025

There was an error while building the doc:

/home/runner/work/cgal/cgal/Hyperbolic_surface_triangulation_2/doc/Hyperbolic_surface_triangulation_2/Hyperbolic_surface_triangulation_2.txt:20: warning: unable to resolve reference to 'Chapter_2D_Periodic_Hyperbolic_Triangulations' for \ref command
/home/runner/work/cgal/cgal/Periodic_4_hyperbolic_triangulation_2/doc/Periodic_4_hyperbolic_triangulation_2/Periodic_4_hyperbolic_triangulation_2.txt:20: warning: unable to resolve reference to 'Chapter_Hyperbolic_Surface_Triangulations' for \ref command

https://github.com/CGAL/cgal/actions/runs/12674566430

@sloriot
Copy link
Member

sloriot commented Jan 10, 2025

Please check CGAL-6.1-Ic-60 for errors and warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants