New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isosurfacing_3 (new package) #6849

Open

JulyCode wants to merge 382 commits into CGAL:master from JulyCode:gsoc2022-isosurface

+12,368 −205

Member

JulyCode commented Sep 15, 2022 •

edited by MaelRL

Loading

Summary of Changes

Extracting isosurfaces from scalar functions is a common method for generating 3D meshes. An isosurface is a subspace with equal values of the function.

ToDo:

Preview Give feedback

Check branch size
TMC_functor::compute_edge_index() uses operator[] on cell_descriptor (violates concept)
Check Orthtree as partition for Marching Cubes after fixing compute_edge_index()
User manual picture with transparent background
MC vs TMC picture
Optimize parallelism
Options

Extra:

Preview Give feedback

Use Isosurfacing_3 in the demo (Isosurface_3_plugin)
Options

Release Management

Affected package(s): Isosurfacing_3
Issue(s) solved (if any): -
Feature/Small Feature (if any): Isosurfacing_3
License and copyright ownership: see feature

This comment was marked as outdated.

Sign in to view

afabri reviewed

View reviewed changes

Isosurfacing_3/doc/Isosurfacing_3/Concepts/IsosurfacingDomain.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Cartesian_topology_base.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Cell_type.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Default_gradients.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Dual_contouring_3.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Dual_contouring_3.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Implicit_domain.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Marching_cubes_3_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Marching_cubes_3_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Marching_cubes_3_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Marching_cubes_3.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Octree_domain.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/examples/Isosurfacing_3/marching_cubes_inrimage.cpp Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Octree_wrapper.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h Outdated Show resolved Hide resolved

MaelRL marked this pull request as ready for review

September 15, 2022 12:14

Member

afabri commented Sep 15, 2022

/build:v1

MaelRL added Not yet approved Feature Work in progress labels

github-actions bot commented Sep 15, 2022

There was an error while building the doc:
/home/runner/work/cgal/cgal/Isosurfacing_3/include/CGAL/Octree_wrapper.h:330: warning: The following parameters of CGAL::Isosurfacing::Octree_wrapper::e_glIndex(const std::size_t &e, const std::size_t &i_idx, const std::size_t &j_idx, const std::size_t &k_idx, const std::size_t &depth) const are not documented:

This comment was marked as outdated.

Sign in to view

Member

afabri commented Sep 15, 2022 •

edited

Loading

The data files have a problem with rights. I think they also need o+r
But more importantly they should be in the package Data so that we do not have millions of bunnies and skulls.

github-actions bot commented Oct 14, 2024

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

JulyCode and others added 9 commits

October 29, 2024 16:06


          Add topological test cases

610820d


          Fix naming error

e531249


          introducing small shift of implicit function value if identical to is…

…ovalue to avoid singular configurations


          making isosurfacing compatible with EPECK (resolves many self-interse…

4ac30ba

…ctions and invalid configurations)


          removing whitespaces

67f8fd7


          removing tabs

676a169


          added missing include

2fb921c


          making compatible with epeck

a1e60de


          asymptotic decider now chooses a more stable basis

087a3f7

adding csg test

MaelRL added the TODO (web) label


          better singular case handling

c3df96f

sloriot added the Under Testing label

soesau and others added 2 commits

December 16, 2024 11:32


          added hidden named parameters for isovalue nudging and interior verte…

750dce6

…x placement


          Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface

d8c521e

Member

afabri commented Dec 16, 2024

@MaelRL we have to take a look at the dependencies. Why Mesh_3 for example ?

sloriot and others added 8 commits

December 17, 2024 09:44


          fix warnings and compilation errors

2eeaeaf


          bugfixes (min/max, typos, proper boolean return for failure case)

96d24be


          removing property map type declaration

d851e3c


          fixes for warnings

729c85c


          improvement of asymptotic decider with different cases

5c79fca


          Add topology verifier

59af6a8


          use std header

3da66d2

TWS

3836c09

Member

sloriot commented Dec 24, 2024

@JulyCode the test you added uses some data that you did not add. Could you please commit them or shall I remove the test?

sloriot removed the Under Testing label

sloriot reviewed

View reviewed changes

Isosurfacing_3/test/Isosurfacing_3/test_topology.cpp

+                  Mesh m;
+                  CGAL::Polygon_mesh_processing::polygon_soup_to_polygon_mesh(points, triangles, m);
+                  assert(connected_components(m) == components);

Member

sloriot Dec 27, 2024

warning: comparison of integers of different signs: 'int' and 'std::size_t' (aka 'unsigned long') [-Wsign-compare]

Member

sloriot Dec 27, 2024

for the 3 assertions

soesau added 3 commits

January 10, 2025 11:17


          deactivating verifier test as it requires a large downloadable set of…

99b057b

… files


          using a different orientation for the hyperbola fitting in case the f…

602968a

…itting fails or a saddle point is not detected


          all test files pass

2d3122d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

janetournois janetournois left review comments

lrineau lrineau left review comments

MaelRL MaelRL left review comments

afabri afabri requested changes

sloriot sloriot left review comments

Labels

CHANGES.md not updated Feature gsoc gsoc-2022 Not yet approved Pkg::Isosurfacing_3 TODO (web) TODO