Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to compute discrete curvatures #6088

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Add functions to compute discrete curvatures #6088

wants to merge 26 commits into from
+712 −30

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Oct 28, 2021 •
edited by MaelRL
Loading

Summary of Changes

Add functions to compute discrete curvatures.

Tentative TODO:

  • discrete curvature for boundary vertices
  • not naive way of computing curvatures when computed at all the vertices of a mesh

Release Management

  • Affected package(s): Polygon_mesh_processing
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): Add discrete curvature
  • Link to compiled documentation (obligatory for small feature) compiled doc
  • License and copyright ownership: no change

@sloriot sloriot added this to the 5.5-beta1 milestone Oct 28, 2021
@sloriot
Copy link
Member Author

sloriot commented Oct 28, 2021

Shall we plug it in the display plugin ?

@lrineau
Copy link
Member

lrineau commented Oct 28, 2021

Shall we plug it in the display plugin ?

That would be a nice way to evaluate the code.

@sloriot
Copy link
Member Author

sloriot commented Oct 29, 2021

Done. Here is what it looks like
Screenshot from 2021-10-29 12-07-39
Screenshot from 2021-10-29 12-08-00

afabri
afabri reviewed Dec 10, 2021
View reviewed changes
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/curvature.h Outdated
const Vector_3 cross = cross_product(v0, v1);
const FT sqcn = squared_length(cross);
if(dot == FT(0))
ki += CGAL_PI/FT(2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this will compile with Epeck.

@afabri
Copy link
Member

afabri commented Dec 10, 2021

Is that going to be documented and submitted as a small feature?

@MaelRL MaelRL added the Not yet approved The feature or pull-request has not yet been approved. label Dec 23, 2021
@MaelRL MaelRL modified the milestones: 5.5-beta, 5.6-beta Mar 28, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 31, 2023
@janetournois janetournois modified the milestones: 6.0-beta, 6.1-beta May 16, 2024
@MaelRL MaelRL removed the Stalled label Dec 9, 2024
@MaelRL MaelRL mentioned this pull request Dec 10, 2024
Closed
@sloriot
Copy link
Member Author

sloriot commented Dec 23, 2024

Successfully tested in CGAL-6.1-Ic-45

@github-actions github-actions bot removed the Tested label Jan 10, 2025
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot
Copy link
Member Author

sloriot commented Jan 20, 2025

Successfully tested in CGAL-6.1-Ic-66

@MaelRL MaelRL changed the title Add functions to compute discrete curvature Add functions to compute discrete curvatures Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelRL MaelRL MaelRL left review comments

@afabri afabri afabri left review comments

Assignees
No one assigned
Labels
CHANGES.md not updated Enhancement Not yet approved The feature or pull-request has not yet been approved. Pkg::PMP Small feature Tested
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
5 participants
@sloriot @lrineau @afabri @MaelRL @janetournois