Deal with the central predicate of periodic triangulations 2D, 3D

CGAL · Sep 27, 2024 · 8bf9639 · 8bf9639
1 parent 42cf247
commit 8bf9639
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 15 deletions.
diff --git a/Periodic_2_triangulation_2/include/CGAL/Periodic_2_Delaunay_triangulation_2.h b/Periodic_2_triangulation_2/include/CGAL/Periodic_2_Delaunay_triangulation_2.h
@@ -5069,8 +5069,7 @@ side_of_oriented_circle(const Point &p0, const Point &p1, const Point &p2,
       if (points[i] == &p0 && (o = orientation(p, p1, p2)) != COLLINEAR)
         return Oriented_side(o);
     }
-  CGAL_assertion(false);
-  return ON_NEGATIVE_SIDE;
+  CGAL_unreachable();
 }
 
 template<class Gt, class Tds>
@@ -5113,8 +5112,7 @@ side_of_oriented_circle(const Point &p0, const Point &p1, const Point &p2,
                                      != COLLINEAR))
         return Oriented_side(orient);
     }
-  CGAL_assertion(false);
-  return ON_NEGATIVE_SIDE;
+  CGAL_unreachable();
 }
 
 template<class Gt, class Tds>

diff --git a/Periodic_2_triangulation_2/include/CGAL/Periodic_2_triangulation_2.h b/Periodic_2_triangulation_2/include/CGAL/Periodic_2_triangulation_2.h
@@ -3800,8 +3800,7 @@ Bounded_side Periodic_2_triangulation_2<Gt, Tds>::side_of_face(const Point &q,
     default:
     {
       // impossible : cannot be on 3 edges for a real triangle
-      CGAL_assertion(false);
-      return ON_BOUNDARY;
+      CGAL_unreachable();
     }
     }
 }
@@ -3863,8 +3862,7 @@ Oriented_side Periodic_2_triangulation_2<Gt, Tds>::oriented_side(Face_handle f,
       return ON_NEGATIVE_SIDE;
     }
 
-  CGAL_assertion(false);
-  return ON_NEGATIVE_SIDE;
+  CGAL_unreachable();
 }
 
 template<class Gt, class Tds>

diff --git a/Periodic_3_triangulation_3/include/CGAL/Periodic_3_Delaunay_triangulation_3.h b/Periodic_3_triangulation_3/include/CGAL/Periodic_3_Delaunay_triangulation_3.h
@@ -1089,8 +1089,7 @@ _side_of_sphere(const Cell_handle& c, const Point& q,
     }
   }
 
-  CGAL_assertion(false);
-  return ON_UNBOUNDED_SIDE;
+  CGAL_unreachable();
 }
 
 template < class Gt, class Tds >

diff --git a/Periodic_3_triangulation_3/include/CGAL/Periodic_3_regular_triangulation_3.h b/Periodic_3_triangulation_3/include/CGAL/Periodic_3_regular_triangulation_3.h
@@ -751,8 +751,7 @@ class Periodic_3_regular_triangulation_3
       }
     }
 
-    CGAL_assertion(false);
-    return ON_UNBOUNDED_SIDE;
+    CGAL_unreachable();
   }
 
   Weighted_point construct_weighted_point(const Weighted_point& p, const Offset &o) const

diff --git a/Periodic_3_triangulation_3/include/CGAL/Periodic_3_triangulation_3.h b/Periodic_3_triangulation_3/include/CGAL/Periodic_3_triangulation_3.h
@@ -2415,7 +2415,7 @@ exact_periodic_locate
     break;
   default:
     // the point cannot lie on four facets
-    CGAL_assertion(false);
+    CGAL_unreachable();
   }
   lo = off_query;
 
@@ -2651,8 +2651,7 @@ inline Bounded_side Periodic_3_triangulation_3<GT,TDS>::side_of_cell(
   default:
     {
       // impossible : cannot be on 4 facets for a real tetrahedron
-      CGAL_assertion(false);
-      return ON_BOUNDARY;
+      CGAL_unreachable();
     }
   }
 } // side_of_cell