Use limits directly instead of Flask-Limiter #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
I tried to modify something around limits and feel that Flask-Limiter is not exactly a good fit to our needs.
rate_limited_resource
decorator is awfully hacky and Flask-Limiter doesn't provide a good way to make more dynamic configuration of limits.What is the new behaviour?
In the same time: Flask-Limiter is just a wrapper on limits library. I found we can use it directly and implement rate limiting in
before_request
instead of relying on decoratorsTest plan
Rate-Limit
header looks good