Keep author field in comments when author is deleted

CERT-Polska · Feb 19, 2024 · df21b3b · df21b3b
1 parent c7608e2
commit df21b3b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/mwdb/schema/comment.py b/mwdb/schema/comment.py
@@ -18,5 +18,5 @@ class CommentRequestSchema(CommentSchemaBase):
 
 class CommentItemResponseSchema(CommentSchemaBase):
     id = fields.Int(required=True, allow_none=False)
-    author = fields.Str(required=True, allow_none=False, attribute="author_login")
+    author = fields.Str(required=True, default=None, attribute="author_login")
     timestamp = UTCDateTime(required=True, allow_none=False)
diff --git a/tests/backend/test_api.py b/tests/backend/test_api.py
@@ -247,4 +247,4 @@ def test_user_delete(admin_session):
     comments = admin_session.get_comments(sample.dhash)
     assert len(comments) == 1
     assert comments[0]["comment"] == "random comment"
-    assert comments[0].get("author") is None
+    assert comments[0]["author"] is None