Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating the checksum-validate GitHub Action into project #16728

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

emvaldes
Copy link
Collaborator

@emvaldes emvaldes commented Dec 5, 2024

This PR Integrating the checksum-validate GitHub Action into project

This PR does not suggest a fix for a currently exploitable issue.

Test Steps:

  1. Validate all performed tasks are successfully completed in this importing process

Changes

  • Importing the external GitHub Action
  • Updating any references to this external repo to be local

Checklist

Process

  • Are there licensing issues with any new dependencies introduced? N/A
  • Includes a summary of what a code reviewer should test/verify? N/A
  • Updated the release notes? N/A
  • Database changes are submitted as a separate PR? N/A
  • DevOps team has been notified if PR requires ops support? We are performing this task ourselves.

Linked Issues

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints? No
  • Does this PR include changes in authentication and/or authorization of existing endpoints? No
  • Does this change introduce new dependencies that need vetting? No
  • Does this change require changes to our infrastructure? No
  • Does logging contain sensitive data? No
  • Does this PR include or remove any sensitive information itself? No

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? N/A
  • Have you ensured logging does not contain sensitive data? N/A
  • Have you received any additional approvals needed for this change? N/A

@emvaldes emvaldes added tech-debt Anything that is purely a technical issue and does not affect functionality github-actions Tracking GitHub Actions items reportstream DevSecOps Team Aq DevSecOps work label github-secrets Tracking GitHub Secrets items labels Dec 5, 2024
@emvaldes emvaldes added this to the in progress milestone Dec 5, 2024
@emvaldes emvaldes self-assigned this Dec 5, 2024
@CDCgov CDCgov deleted a comment from github-actions bot Dec 6, 2024
@CDCgov CDCgov deleted a comment from github-actions bot Dec 6, 2024
@emvaldes emvaldes changed the title Integrating the checksum-validate-action GitHub Action into project Integrating the checksum-validate GitHub Action into project Dec 6, 2024
@emvaldes emvaldes requested a review from devopsmatt December 6, 2024 02:21
@emvaldes emvaldes removed the github-secrets Tracking GitHub Secrets items label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Test Results

1 255 tests  ±0   1 251 ✅ ±0   7m 49s ⏱️ +3s
  164 suites ±0       4 💤 ±0 
  164 files   ±0       0 ❌ ±0 

Results for commit 3eadd92. ± Comparison against base commit 9d4321d.

Copy link

github-actions bot commented Dec 6, 2024

Integration Test Results

 59 files   59 suites   38m 14s ⏱️
423 tests 413 ✅ 10 💤 0 ❌
426 runs  416 ✅ 10 💤 0 ❌

Results for commit 3eadd92.

@emvaldes emvaldes marked this pull request as ready for review December 6, 2024 13:45
@emvaldes emvaldes requested a review from a team as a code owner December 6, 2024 13:45
Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emvaldes emvaldes merged commit fd1ce28 into main Dec 6, 2024
20 checks passed
@emvaldes emvaldes deleted the devsecops/emvaldes/checksum-validate branch December 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevSecOps Team Aq DevSecOps work label github-actions Tracking GitHub Actions items reportstream tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing JosiahSiegel GHA: [email protected]
2 participants