-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the jwt-verifier group in /prime-router with 2 updates #13329
Bump the jwt-verifier group in /prime-router with 2 updates #13329
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Test Results1 092 tests ±0 1 054 ✅ - 34 5m 44s ⏱️ -2s For more details on these failures, see this check. Results for commit fee5c92. ± Comparison against base commit 3c03a1a. ♻️ This comment has been updated with latest results. |
There is a feature branch with most of the issues in merging this resolved The ProblemWe use a method Compounding the problemThe library provides a Current ConclusionWe are going to wait until the More InfoSecurity ConcernThe general consensus is that we should not be unpacking the payload before verifying the signature if possible. Possible solutionsForce the libraryRemove the Move existing logic inside KeyLocatorMove the existing logic flow of peeking the payload and trying keys into a KeyLocator. Unique KIDsMake the Custom HeaderWe can add our own new header to the JWT that represents the organization ID we are authorizing as Exposed IssuerThere are some IETF discussions around exposing the issuer somehow. Last discussion was in early January and the draft expires 4/25/2024 so low optimism on this coming to fruition. Related reading:GitHub Issue - Closed issue on the library with the same problem we are having (needing access to the issuer in the payload) |
@dependabot recreate |
60f1382
to
f2b5f09
Compare
8605274
to
a4edd73
Compare
a4edd73
to
af49b2d
Compare
@dependabot recreate |
e9c20a7
to
dbda63b
Compare
@dependabot recreate |
eb6a637
to
96d1906
Compare
96d1906
to
b0458ce
Compare
@dependabot recreate |
df15ada
to
a75f702
Compare
a75f702
to
62b8833
Compare
0bef162
to
087cdaf
Compare
bb4c210
to
9e28acf
Compare
9e28acf
to
3706486
Compare
679d093
to
2df5e0b
Compare
Bumps the jwt-verifier group in /prime-router with 2 updates: com.okta.jwt:okta-jwt-verifier and com.okta.jwt:okta-jwt-verifier-impl. Updates `com.okta.jwt:okta-jwt-verifier` from 0.5.7 to 0.5.8 Updates `com.okta.jwt:okta-jwt-verifier-impl` from 0.5.7 to 0.5.8 --- updated-dependencies: - dependency-name: com.okta.jwt:okta-jwt-verifier dependency-type: direct:production update-type: version-update:semver-patch dependency-group: jwt-verifier - dependency-name: com.okta.jwt:okta-jwt-verifier-impl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: jwt-verifier ... Signed-off-by: dependabot[bot] <[email protected]>
2df5e0b
to
6a533da
Compare
superseded by #14947 |
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the jwt-verifier group in /prime-router with 2 updates: com.okta.jwt:okta-jwt-verifier and com.okta.jwt:okta-jwt-verifier-impl.
Updates
com.okta.jwt:okta-jwt-verifier
from 0.5.7 to 0.5.8Updates
com.okta.jwt:okta-jwt-verifier-impl
from 0.5.7 to 0.5.8You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions