Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename _dist postfixes to _prior when used as a prior #67

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 commented Feb 23, 2024

Simple PR.

When a Distribution is used as a prior in any Turing model the postfix _prior is used. Other uses, e.g. the underlying continuous distribution of the generation interval which is discretised have _dist postfix.

Closes #66

@SamuelBrand1 SamuelBrand1 linked an issue Feb 23, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (39fd99a) to head (4ea4c3c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          123       123           
=========================================
  Hits           123       123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A comment unrelated to this PR about duplicative variable names.

@seabbs seabbs merged commit 5cc7265 into main Feb 23, 2024
5 checks passed
@seabbs seabbs deleted the 66-standardise-use-of-_dist-and-_prior branch February 23, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standardise use of _dist and _prior
3 participants