Stop string instantiations

CCNetMC · Dec 4, 2023 · d6d5f1b · d6d5f1b
1 parent f6c6283
commit d6d5f1b
Show file tree

Hide file tree

Showing 12 changed files with 17 additions and 18 deletions.
diff --git a/src/com/dogonfire/gods/commands/CommandListGods.java b/src/com/dogonfire/gods/commands/CommandListGods.java
@@ -135,7 +135,7 @@ class God
 	God(String godName, int godPower, int godbelievers)
 	{
 		this.power = godPower;
-		this.name = new String(godName);
+		this.name = godName;
 		this.believers = godbelievers;
 	}
 }

diff --git a/src/com/dogonfire/gods/managers/GodManager.java b/src/com/dogonfire/gods/managers/GodManager.java
@@ -1043,7 +1043,7 @@ public String getGodDescription(String godName)
 		String description = this.godsConfig.getString(godName + ".Description");
 		if (description == null)
 		{
-			description = new String("No description :/");
+			description = "No description :/";
 		}
 		return description;
 	}

diff --git a/src/com/dogonfire/gods/tasks/GiveHolyArtifactTask.java b/src/com/dogonfire/gods/tasks/GiveHolyArtifactTask.java
@@ -25,7 +25,7 @@ public GiveHolyArtifactTask(Gods instance, String god, GodManager.GodType godTyp
 	{
 		this.plugin = instance;
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.godType = godType;
 		this.speak = godspeak;
 	}

diff --git a/src/com/dogonfire/gods/tasks/GiveItemTask.java b/src/com/dogonfire/gods/tasks/GiveItemTask.java
@@ -25,7 +25,7 @@ public GiveItemTask(Gods instance, String god, Player p, Material material, bool
 	{
 		this.plugin = instance;
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.itemType = material;
 		this.speak = godspeak;
 	}

diff --git a/src/com/dogonfire/gods/tasks/GodSpeakTask.java b/src/com/dogonfire/gods/tasks/GodSpeakTask.java
@@ -24,22 +24,22 @@ public GodSpeakTask(Gods instance, String gname, UUID playerId, String player, S
 	{
 		this.plugin = instance;
 		this.playerId = playerId;
-		this.godName = new String(gname);
+		this.godName = gname;
 		this.message = null;
 	}
 
 	public GodSpeakTask(Gods instance, String gname, UUID playerId, String player, String type, int a, LANGUAGESTRING m)
 	{
 		this.plugin = instance;
 		this.playerId = playerId;
-		this.godName = new String(gname);
+		this.godName = gname;
 		this.message = m;
 
-		this.playerNameString = new String(player);
+		this.playerNameString = player;
 		this.amount = a;
 		if (type != null)
 		{
-			this.typeString = new String(type);
+			this.typeString = type;
 		}
 		else
 		{

diff --git a/src/com/dogonfire/gods/tasks/HealPlayerTask.java b/src/com/dogonfire/gods/tasks/HealPlayerTask.java
@@ -22,7 +22,7 @@ public HealPlayerTask(Gods instance, String god, Player p, LANGUAGESTRING speak)
 	{
 		this.plugin = instance;
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.languageString = speak;
 	}
 

diff --git a/src/com/dogonfire/gods/tasks/SpawnHostileMobsTask.java b/src/com/dogonfire/gods/tasks/SpawnHostileMobsTask.java
@@ -18,7 +18,7 @@ public SpawnHostileMobsTask(Gods instance, String god, Player p, EntityType enti
 		this.plugin = instance;
 		this.numberOfMobs = n;
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.mobType = entityType;
 	}
 

diff --git a/src/com/dogonfire/gods/tasks/TaskGiveHolyArtifact.java b/src/com/dogonfire/gods/tasks/TaskGiveHolyArtifact.java
@@ -23,7 +23,7 @@ public class TaskGiveHolyArtifact extends Task
 	public TaskGiveHolyArtifact(String god, GodType godType, Player p, boolean godspeak)
 	{
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.godType = godType;
 		this.speak = godspeak;
 	}

diff --git a/src/com/dogonfire/gods/tasks/TaskGiveItem.java b/src/com/dogonfire/gods/tasks/TaskGiveItem.java
@@ -20,7 +20,7 @@ public class TaskGiveItem extends Task {
 
 	public TaskGiveItem(String god, Player p, ItemStack item, boolean godspeak) {
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.item = item;
 		this.speak = godspeak;
 	}

diff --git a/src/com/dogonfire/gods/tasks/TaskGodSpeak.java b/src/com/dogonfire/gods/tasks/TaskGodSpeak.java
@@ -17,19 +17,19 @@ public class TaskGodSpeak extends Task {
 
 	public TaskGodSpeak(String gname, UUID playerId, String player, String type, int a) {
 		this.playerId = playerId;
-		this.godName = new String(gname);
+		this.godName = gname;
 		this.message = null;
 	}
 
 	public TaskGodSpeak(String gname, UUID playerId, String player, String type, int a, LanguageManager.LANGUAGESTRING m) {
 		this.playerId = playerId;
-		this.godName = new String(gname);
+		this.godName = gname;
 		this.message = m;
 
-		this.playerNameString = new String(player);
+		this.playerNameString = player;
 		this.amount = a;
 		if (type != null) {
-			this.typeString = new String(type);
+			this.typeString = type;
 		} else {
 			type = "";
 		}

diff --git a/src/com/dogonfire/gods/tasks/TaskHealPlayer.java b/src/com/dogonfire/gods/tasks/TaskHealPlayer.java
@@ -19,7 +19,7 @@ public class TaskHealPlayer extends Task
 	public TaskHealPlayer(String god, Player p, LanguageManager.LANGUAGESTRING speak)
 	{
 		this.player = p;
-		this.godName = new String(god);
+		this.godName = god;
 		this.languageString = speak;
 	}
 

diff --git a/src/com/dogonfire/gods/tasks/TaskSpawnHostileMobs.java b/src/com/dogonfire/gods/tasks/TaskSpawnHostileMobs.java
@@ -12,7 +12,6 @@ public class TaskSpawnHostileMobs extends Task {
 	public TaskSpawnHostileMobs(String god, Player p, EntityType entityType, int n) {
 		this.numberOfMobs = n;
 		this.player = p;
-		new String(god);
 		this.mobType = entityType;
 	}