Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip endpoint discovery #3

Merged
merged 1 commit into from
May 9, 2024
Merged

skip endpoint discovery #3

merged 1 commit into from
May 9, 2024

Conversation

DanNiESh
Copy link
Collaborator

@DanNiESh DanNiESh commented May 8, 2024

This PR adds the logic to skip esi-leap endpoint discovery, so that esisdk won't make call to http://129.10.5.142:7777 at first to obtain the endpoint url.

@tzumainn
Copy link
Collaborator

tzumainn commented May 8, 2024

oh, interesting! is this code also somewhere in the openstack codebase?

@DanNiESh
Copy link
Collaborator Author

DanNiESh commented May 8, 2024

oh, interesting! is this code also somewhere in the openstack codebase?

Yeah, i found it here: https://github.com/openstack/openstacksdk/blob/ff2d0a5bd0b929d5fc15e5b0cfabe2b57a33f722/openstack/service_description.py#L254. But when I directly used the code here, it made call to http://129.10.5.142:7777/leases/ rather than http://129.10.5.142:7777/v1/leases/, so i restricted the endpoint url to be '{}/v{}'.format(ep_override, version_string)`

@tzumainn
Copy link
Collaborator

tzumainn commented May 9, 2024

looks good - thanks!

@tzumainn tzumainn merged commit 43215ec into CCI-MOC:main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants