Update esi sdk

[DanNiESh]

Related issue: CCI-MOC/esi#536

[tzumainn]

Looks good! Can you update the description of the PR to be a bit more specific about the contents - e.g., "updates to object attributes, addition of functional tests"?

[DanNiESh]

Looks good! Can you update the description of the PR to be a bit more specific about the contents - e.g., "updates to object attributes, addition of functional tests"?

Done! I'm now working on python-esileapclient PR. I might update this PR slightly (attribute naming, etc.) to sync with python-esileapclient if necessary. I 'll let you know when this one is in final stage to review.

[tzumainn]

Okay, sounds good!

[tzumainn]

Looks good! I think it could use one thing: in the README, could you add a quick explanation of how you'd use this sdk within a python script?

[DanNiESh]

I've updated the README.md, let me know what you think!

[tzumainn]

Thanks for adding the README! The code works well; there's just a few minor inaccuracies in the documentation that I've noted.

Could you also add a connect method, similar to https://github.com/openstack/openstacksdk/blob/master/openstack/__init__.py? What this allows one to do is have code like:

import openstack

conn = openstack.connect()
nodes = conn.baremetal.nodes(details=True)

And the openstacksdk will simply pull from your current environment.

[DanNiESh]

Thanks for adding the README! The code works well; there's just a few minor inaccuracies in the documentation that I've noted.

Could you also add a connect method, similar to https://github.com/openstack/openstacksdk/blob/master/openstack/__init__.py? What this allows one to do is have code like:

import openstack

conn = openstack.connect()
nodes = conn.baremetal.nodes(details=True)

And the openstacksdk will simply pull from your current environment.

Done!

[tzumainn]

This looks great - thanks!