chore: LiquidBounce Client-ID #36
clippy
5 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 5 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.79.0-nightly (a7e4de13c 2024-03-19)
- cargo 1.79.0-nightly (2fe739fcf 2024-03-15)
- clippy 0.1.78 (a7e4de1 2024-03-19)
Annotations
Check warning on line 560 in azalea-client/src/packet_handling/game.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> azalea-client/src/packet_handling/game.rs:560:29
|
560 | ... info.display_name = updated_info.display_name.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `info.display_name.clone_from(&updated_info.display_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 326 in azalea-physics/src/collision/shape.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> azalea-physics/src/collision/shape.rs:326:49
|
326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4)
| ^^^^^^^^ help: change this to: `coords2`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 326 in azalea-physics/src/collision/shape.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> azalea-physics/src/collision/shape.rs:326:39
|
326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4)
| ^^^^^^^^ help: change this to: `coords1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 83 in azalea-brigadier/src/context/command_context_builder.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> azalea-brigadier/src/context/command_context_builder.rs:83:9
|
83 | self.modifier = node.read().modifier.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.modifier.clone_from(&node.read().modifier)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 66 in azalea-brigadier/src/context/command_context_builder.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> azalea-brigadier/src/context/command_context_builder.rs:66:9
|
66 | self.command = command.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.command.clone_from(command)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default