change auth to liquidbounce #17
clippy
5 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 5 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.0-nightly (595bc6f00 2024-01-05)
- cargo 1.77.0-nightly (add15366e 2024-01-02)
- clippy 0.1.77 (595bc6f 2024-01-05)
Annotations
Check warning on line 602 in azalea/src/swarm/mod.rs
github-actions / clippy
you are using an explicit closure for cloning elements
warning: you are using an explicit closure for cloning elements
--> azalea/src/swarm/mod.rs:602:25
|
602 | let proxy = self.proxies.choose(&mut thread_rng()).map(|p| p.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.proxies.choose(&mut thread_rng()).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
Check warning on line 162 in azalea/src/pathfinder/world.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
warning: this `let...else` may be rewritten with the `?` operator
--> azalea/src/pathfinder/world.rs:160:9
|
160 | / let Some(chunk) = world.chunks.get(&chunk_pos) else {
161 | | return None;
162 | | };
| |__________^ help: replace it with: `let chunk = world.chunks.get(&chunk_pos)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
Check warning on line 111 in azalea-client/src/packet_handling/configuration.rs
github-actions / clippy
single-character string constant used as pattern
warning: single-character string constant used as pattern
--> azalea-client/src/packet_handling/configuration.rs:111:45
|
111 | .trim_start_matches("\"")
| ^^^^ help: try using a `char` instead: `'\"'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
Check warning on line 284 in azalea-protocol/src/connect.rs
github-actions / clippy
manual implementation of `Option::map`
warning: manual implementation of `Option::map`
--> azalea-protocol/src/connect.rs:281:28
|
281 | let auth = match proxy.auth {
| ____________________________^
282 | | Some(user_key) => Some(user_key),
283 | | None => None,
284 | | };
| |_________________^ help: try: `proxy.auth.map(|user_key| user_key)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
Check warning on line 284 in azalea-protocol/src/connect.rs
github-actions / clippy
this match expression is unnecessary
warning: this match expression is unnecessary
--> azalea-protocol/src/connect.rs:281:28
|
281 | let auth = match proxy.auth {
| ____________________________^
282 | | Some(user_key) => Some(user_key),
283 | | None => None,
284 | | };
| |_________________^ help: replace it with: `proxy.auth`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match
= note: `#[warn(clippy::needless_match)]` on by default