Skip to content

Merge branch 'socks5' into dev #15

Merge branch 'socks5' into dev

Merge branch 'socks5' into dev #15

GitHub Actions / clippy succeeded Jan 6, 2024 in 1s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.77.0-nightly (595bc6f00 2024-01-05)
  • cargo 1.77.0-nightly (add15366e 2024-01-02)
  • clippy 0.1.77 (595bc6f 2024-01-05)

Annotations

Check warning on line 284 in azalea-protocol/src/connect.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
   --> azalea-protocol/src/connect.rs:281:28
    |
281 |                   let auth = match proxy.auth {
    |  ____________________________^
282 | |                     Some(user_key) => Some(user_key),
283 | |                     None => None,
284 | |                 };
    | |_________________^ help: try: `proxy.auth.map(|user_key| user_key)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
    = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 284 in azalea-protocol/src/connect.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match expression is unnecessary

warning: this match expression is unnecessary
   --> azalea-protocol/src/connect.rs:281:28
    |
281 |                   let auth = match proxy.auth {
    |  ____________________________^
282 | |                     Some(user_key) => Some(user_key),
283 | |                     None => None,
284 | |                 };
    | |_________________^ help: replace it with: `proxy.auth`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match
    = note: `#[warn(clippy::needless_match)]` on by default