Skip to content

fix: unwrap no more #52

fix: unwrap no more

fix: unwrap no more #52

Triggered via push May 26, 2024 10:30
Status Success
Total duration 2m 0s
Artifacts

check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

68 warnings
you are using an explicit closure for cloning elements: azalea/src/swarm/mod.rs#L639
warning: you are using an explicit closure for cloning elements --> azalea/src/swarm/mod.rs:639:25 | 639 | let proxy = self.proxies.choose(&mut thread_rng()).map(|p| p.clone()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.proxies.choose(&mut thread_rng()).cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default
usage of a legacy numeric constant: azalea-client/src/task_pool.rs#L80
warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:80:30 | 80 | max_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 80 | max_threads: usize::MAX, | ~~~~~~~~~~
usage of a legacy numeric constant: azalea-client/src/task_pool.rs#L61
warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:61:32 | 61 | max_total_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 61 | max_total_threads: usize::MAX, | ~~~~~~~~~~
unused import: `azalea_protocol::packets::configuration::serverbound_resource_pack_packet::ServerboundResourcePackPacket`: azalea-client/src/packet_handling/configuration.rs#L8
warning: unused import: `azalea_protocol::packets::configuration::serverbound_resource_pack_packet::ServerboundResourcePackPacket` --> azalea-client/src/packet_handling/configuration.rs:8:5 | 8 | use azalea_protocol::packets::configuration::serverbound_resource_pack_packet::ServerboundResourcePackPacket; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: azalea-physics/src/collision/shape.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:49 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: azalea-physics/src/collision/shape.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:39 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
field `only_suffocating_blocks` is never read: azalea-physics/src/collision/world_collisions.rs#L87
warning: field `only_suffocating_blocks` is never read --> azalea-physics/src/collision/world_collisions.rs:87:9 | 82 | pub struct BlockCollisionsState<'a> { | -------------------- field in this struct ... 87 | pub only_suffocating_blocks: bool, | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
manual implementation of `Option::map`: azalea-protocol/src/connect.rs#L281
warning: manual implementation of `Option::map` --> azalea-protocol/src/connect.rs:281:28 | 281 | let auth = match proxy.auth { | ____________________________^ 282 | | Some(user_key) => Some(user_key), 283 | | None => None, 284 | | }; | |_________________^ help: try: `proxy.auth.map(|user_key| user_key)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default
this match expression is unnecessary: azalea-protocol/src/connect.rs#L281
warning: this match expression is unnecessary --> azalea-protocol/src/connect.rs:281:28 | 281 | let auth = match proxy.auth { | ____________________________^ 282 | | Some(user_key) => Some(user_key), 283 | | None => None, 284 | | }; | |_________________^ help: replace it with: `proxy.auth` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match = note: `#[warn(clippy::needless_match)]` on by default
unused import: `tracing::info`: azalea-protocol/src/read.rs#L12
warning: unused import: `tracing::info` --> azalea-protocol/src/read.rs:12:5 | 12 | use tracing::info; | ^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
mutable key type: azalea-brigadier/src/command_dispatcher.rs#L68
warning: mutable key type --> azalea-brigadier/src/command_dispatcher.rs:68:9 | 68 | let mut errors = HashMap::<Rc<CommandNode<S>>, CommandSyntaxException>::new(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type = note: `#[warn(clippy::mutable_key_type)]` on by default
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L351
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:351:12 | 351 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L344
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:344:12 | 344 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L337
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:337:12 | 337 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L327
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:327:12 | 327 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L318
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:318:12 | 318 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L309
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:309:12 | 309 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L289
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:289:12 | 289 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L248
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:248:12 | 248 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L238
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:238:12 | 238 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L194
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:194:12 | 194 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L179
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:179:11 | 179 | #[cfg(not(feature = "strict_registry"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L144
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:144:7 | 144 | #[cfg(feature = "strict_registry")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L133
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:133:12 | 133 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L124
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:124:12 | 124 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L116
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:116:12 | 116 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L105
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:105:12 | 105 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L94
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:94:12 | 94 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L82
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:82:12 | 82 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
usage of a legacy numeric method: azalea-buf/src/write.rs#L140
warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:140:42 | 140 | value = (value >> 7) & (i64::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 140 | value = (value >> 7) & (i64::MAX >> 6); | ~~~
usage of a legacy numeric method: azalea-buf/src/write.rs#L44
warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:44:42 | 44 | value = (value >> 7) & (i32::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 44 | value = (value >> 7) & (i32::MAX >> 6); | ~~~
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
you are using an explicit closure for cloning elements: azalea/src/swarm/mod.rs#L639
warning: you are using an explicit closure for cloning elements --> azalea/src/swarm/mod.rs:639:25 | 639 | let proxy = self.proxies.choose(&mut thread_rng()).map(|p| p.clone()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.proxies.choose(&mut thread_rng()).cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default
usage of a legacy numeric constant: azalea-client/src/task_pool.rs#L80
warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:80:30 | 80 | max_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 80 | max_threads: usize::MAX, | ~~~~~~~~~~
usage of a legacy numeric constant: azalea-client/src/task_pool.rs#L61
warning: usage of a legacy numeric constant --> azalea-client/src/task_pool.rs:61:32 | 61 | max_total_threads: std::usize::MAX, | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 61 | max_total_threads: usize::MAX, | ~~~~~~~~~~
unused import: `azalea_protocol::packets::configuration::serverbound_resource_pack_packet::ServerboundResourcePackPacket`: azalea-client/src/packet_handling/configuration.rs#L8
warning: unused import: `azalea_protocol::packets::configuration::serverbound_resource_pack_packet::ServerboundResourcePackPacket` --> azalea-client/src/packet_handling/configuration.rs:8:5 | 8 | use azalea_protocol::packets::configuration::serverbound_resource_pack_packet::ServerboundResourcePackPacket; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: azalea-physics/src/collision/shape.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:49 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: azalea-physics/src/collision/shape.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/shape.rs:326:39 | 326 | IndexMerger::new_indirect(&coords1, &coords2, var3, var4) | ^^^^^^^^ help: change this to: `coords1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
field `only_suffocating_blocks` is never read: azalea-physics/src/collision/world_collisions.rs#L87
warning: field `only_suffocating_blocks` is never read --> azalea-physics/src/collision/world_collisions.rs:87:9 | 82 | pub struct BlockCollisionsState<'a> { | -------------------- field in this struct ... 87 | pub only_suffocating_blocks: bool, | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
manual implementation of `Option::map`: azalea-protocol/src/connect.rs#L281
warning: manual implementation of `Option::map` --> azalea-protocol/src/connect.rs:281:28 | 281 | let auth = match proxy.auth { | ____________________________^ 282 | | Some(user_key) => Some(user_key), 283 | | None => None, 284 | | }; | |_________________^ help: try: `proxy.auth.map(|user_key| user_key)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default
this match expression is unnecessary: azalea-protocol/src/connect.rs#L281
warning: this match expression is unnecessary --> azalea-protocol/src/connect.rs:281:28 | 281 | let auth = match proxy.auth { | ____________________________^ 282 | | Some(user_key) => Some(user_key), 283 | | None => None, 284 | | }; | |_________________^ help: replace it with: `proxy.auth` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match = note: `#[warn(clippy::needless_match)]` on by default
unused import: `tracing::info`: azalea-protocol/src/read.rs#L12
warning: unused import: `tracing::info` --> azalea-protocol/src/read.rs:12:5 | 12 | use tracing::info; | ^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
mutable key type: azalea-brigadier/src/command_dispatcher.rs#L68
warning: mutable key type --> azalea-brigadier/src/command_dispatcher.rs:68:9 | 68 | let mut errors = HashMap::<Rc<CommandNode<S>>, CommandSyntaxException>::new(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type = note: `#[warn(clippy::mutable_key_type)]` on by default
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L351
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:351:12 | 351 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L344
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:344:12 | 344 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L337
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:337:12 | 337 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L327
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:327:12 | 327 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L318
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:318:12 | 318 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L309
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:309:12 | 309 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L289
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:289:12 | 289 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L248
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:248:12 | 248 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L238
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:238:12 | 238 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L194
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:194:12 | 194 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L179
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:179:11 | 179 | #[cfg(not(feature = "strict_registry"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L144
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:144:7 | 144 | #[cfg(feature = "strict_registry")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L133
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:133:12 | 133 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L124
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:124:12 | 124 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L116
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:116:12 | 116 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L105
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:105:12 | 105 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L94
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:94:12 | 94 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
unexpected `cfg` condition value: `strict_registry`: azalea-core/src/registry_holder.rs#L82
warning: unexpected `cfg` condition value: `strict_registry` --> azalea-core/src/registry_holder.rs:82:12 | 82 | #[cfg_attr(feature = "strict_registry", simdnbt(deny_unknown_fields))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bevy_ecs` and `serde` = help: consider adding `strict_registry` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default
usage of a legacy numeric method: azalea-buf/src/write.rs#L140
warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:140:42 | 140 | value = (value >> 7) & (i64::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 140 | value = (value >> 7) & (i64::MAX >> 6); | ~~~
usage of a legacy numeric method: azalea-buf/src/write.rs#L44
warning: usage of a legacy numeric method --> azalea-buf/src/write.rs:44:42 | 44 | value = (value >> 7) & (i32::max_value() >> 6); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 44 | value = (value >> 7) & (i32::MAX >> 6); | ~~~