feat(ProxyManager): mass-importing proxies #5069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use (to fix detekt)
…feat/mass-proxy-importing
* Added multi atlas support * Fix detekt * Stop using the test atlas size
…from clipboard and from file mfw it's just a 4 line change, why didn't I do this before when I added the endpoints?...
…ented imports & fix indentation
…o feat/mass-proxy-importing
DataM0del
changed the title
1zun4
reviewed
Dec 28, 2024
Comment on lines
+59
to
+66
| private val FALLBACK_PING_SERVERS = listOf( | ||
| "mc.hypixel.net", | ||
| "crescentkingdom.com", | ||
| "gratopia.gg", | ||
| "terranova.mc.gg", | ||
| "play.arcanecloud.net", | ||
| "ping.liquidproxy.net" | ||
| ) |
There was a problem hiding this comment.
No, we will not use this. The LiquidProxy Ping Server serves it's purpose to respond with the IP address of the proxy, without we are not able to detect the outgoing IP of a proxy.
There was a problem hiding this comment.
Oh. But what about the server list idea? Aren't we supposed to reuse the server list as ping servers? because I can tell you that no one would want to join a server which shows their IP as the MOTD or the kick message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mass-importing proxies (see #4606 for previous PR)
Because I want to mass import proxies from a text file that is splitted by a newline (
\n)Fixes #4599
reopened because izuna forgot to change the base branch for some PRs before deleting the nextgen-1.21.4 branch