Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Minecraft 1.21.4 #4980

Draft
wants to merge 16 commits into
base: nextgen
Choose a base branch
from
Draft

feat: Minecraft 1.21.4 #4980

wants to merge 16 commits into from
+2,301 −1,819

Conversation

ccetl
Copy link
Contributor

@ccetl ccetl commented Dec 20, 2024 •
edited
Loading

Ports the client to 1.21.4. TODOs:

  • finish reimplementing the blur ui shader (-> refactor overlay sampler to uniformI)
    • fix weird nametag text rendering when spoofing the main framebuffer
  • Esp
    • fix the "glow" making entities semi transparent
    • finish the reimplementation of the outline mode
  • calculate the damage dealt to the fakeplayer correctly
  • check if using bundles slow you down (and therefore should be included in NoSlow)
  • Framebuffershaders and UI blur break the HUD when used without Nametags enabled

Non-Goals (should be implemented separately):

  • take the 1.21.4 tnt minecard additional parameters to calculate the explosion damage into account
  • send the tick end packet after every move packet

The code to render the browser image is taken from #4452.

ccetl added 2 commits December 20, 2024 14:44
@ccetl
feat: 1.21.4
084fb94
@ccetl
Merge remote-tracking branch 'refs/remotes/origin/latest' into 1.21.4
8e90f63 
# Conflicts:
#	src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/player/ModuleSmartEat.kt
#	src/main/kotlin/net/ccbluex/liquidbounce/utils/block/ChunkScanner.kt
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 20, 2024
View reviewed changes
...bluex/liquidbounce/features/module/modules/movement/liquidwalk/modes/LiquidWalkVerusB3901.kt Fixed Show fixed Hide fixed
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/render/ModuleCustomAmbience.kt Fixed Show fixed Hide fixed
...liquidbounce/features/module/modules/world/scaffold/techniques/ScaffoldGodBridgeTechnique.kt Fixed Show fixed Hide fixed
src/main/kotlin/net/ccbluex/liquidbounce/integration/browser/BrowserDrawer.kt Fixed Show fixed Hide fixed
src/main/kotlin/net/ccbluex/liquidbounce/render/shader/shaders/OutlineShader.kt Fixed Show fixed Hide fixed
src/main/kotlin/net/ccbluex/liquidbounce/script/bindings/api/ScriptNetworkUtil.kt Fixed Show fixed Hide fixed
src/main/kotlin/net/ccbluex/liquidbounce/utils/entity/InputAdditions.kt Fixed Show fixed Hide fixed
src/main/kotlin/net/ccbluex/liquidbounce/utils/entity/InputAdditions.kt Fixed Show fixed Hide fixed
@DataM0del DataM0del mentioned this pull request Dec 20, 2024
Closed
6 tasks
@DataM0del
Copy link
Contributor

I'm going to probably now work on this branch instead of mine, since this is better than mine and I closed it anyways (because no stupid rendering offset momento), and would probably Forever Detekted™.

DataM0del
DataM0del suggested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@DataM0del DataM0del left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no downgrading of Kotlin 🙏

gradle.properties Outdated Show resolved Hide resolved
gradle.properties
# mcef
mcef_version=1.3.1-1.21.1
mcef_version=1.3.0-1.21.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the day that @1zun4 will release MCEF 1.3.1 for 1.21.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that it does not matter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that it does not matter?

Yes, but I should probably fork MCEF, pull the upstream changes from 1.21.1, and get ccetl to use mine like I did in my PR. Or you could just click the merge button in the branch and release it.

...t/ccbluex/liquidbounce/injection/mixins/minecraft/network/MixinClientPlayNetworkHandler.java Outdated Show resolved Hide resolved
...ain/java/net/ccbluex/liquidbounce/injection/mixins/minecraft/render/MixinEntityRenderer.java Show resolved Hide resolved
@DataM0del
Copy link
Contributor

fix the "glow" making entities semi transparent

I think that's because I forgot to invert a boolean or something, it was fixed in 91d2b58

@DataM0del
Copy link
Contributor

DataM0del commented Dec 21, 2024 •
edited
Loading

It seems like the ExplodeBypass exploit on loyisa crashes LiquidBounce successfully (it doesn't instantly crash and close though).
image
image

ccetl and others added 3 commits December 21, 2024 09:53
@DataM0del
Copy link
Contributor

detekted

@DataM0del
Copy link
Contributor

undetekted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DataM0del DataM0del DataM0del requested changes

@1zun4 1zun4 1zun4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccetl @DataM0del @1zun4