Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Nextgen): Baritone Integration #4918
base: nextgen
Are you sure you want to change the base?
feat(Nextgen): Baritone Integration #4918
Changes from all commits
a3da835
1f954e9
c307c25
371e6c1
5d33c65
f95f7f1
474d3d8
0f99074
337dd4b
9585b2a
c4756d8
de974aa
e1adb81
2a87252
04f7e01
237911a
0c4b66e
182e8a4
3942d1c
d6e86ce
5c33c28
f8f96c3
c45d7f2
d53784e
7fa8b8e
b0087a0
432d33d
a76f779
0671613
9d9df04
578f2cb
7c67495
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this is the desired behavior? If LiquidBounce forced the W keybind to be on and the player pressed W at the same time, the moveForward value would end up at
2.0
(MixinInput.proceedKeyboardTick + PlayerMovementInput.tick)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a terrible injection point. This does not consider other code that might change the setting (bypassing the command). Additionally, using
ordinal
guarantees that the injection point breaks with the next baritone release.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hacky and redundant as
Value<*>
already implementsonChanged
.My suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rotation works for Look behavior