feat: Slowness NoSlow #4888
Open
feat: Slowness NoSlow #4888
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1zun4
reviewed
Dec 15, 2024
Comment on lines
+37
to
+43
| player.attributes.getCustomInstance(EntityAttributes.GENERIC_MOVEMENT_SPEED)?.updateModifier( | ||
| EntityAttributeModifier( | ||
| Identifier.of("effect.slowness"), | ||
| -multiplier * (slowness + 1.0), | ||
| EntityAttributeModifier.Operation.ADD_MULTIPLIED_TOTAL | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I don't like the idea of editing the effect like that. It should really hook it where it's applied, I guess?
There was a problem hiding this comment.
but then we can't modify pre existing effects
There was a problem hiding this comment.
No, I mean where it applies the effect. Not where the effect is applied.
There was a problem hiding this comment.
If you mean this, it does nothing
There was a problem hiding this comment.
the reason this does nothing is because the attribute is applied by the server and not the client, we would have to modify the attribute when we receive the attribute packet, which as I said before, won't let us disable this, or modify the multiplier after the effect is applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.