-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added velocity hit feature #4878
base: nextgen
Are you sure you want to change the base?
Conversation
get detekted!!! |
Actually no, load the default gomme config and enable this feature. Never got banned, just adjust the extended reach |
Did laugh |
Do what you want I don't care at all |
No what he means is the code quality tool "Detekt". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I had a similar idea but didn't get to do it so far, but this looks promising. The code needs clean up though, formatting is quite off and a lot of useless semicolons and empty spaces.
Thank you it's my first contribution in kotlin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me ™️, just fix the (unfunny joke start) "detektions" (unfunny joke end)
...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/killaura/ModuleKillAura.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should fix the detekt errors:
...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt
Outdated
Show resolved
Hide resolved
...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt
Outdated
Show resolved
Hide resolved
...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt
Outdated
Show resolved
Hide resolved
...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt
Outdated
Show resolved
Hide resolved
...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/velocity/ModuleVelocity.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/velocity/ModuleVelocity.kt
Outdated
Show resolved
Hide resolved
...ccbluex/liquidbounce/features/module/modules/combat/killaura/features/KillAuraVelocityHit.kt
Outdated
Show resolved
Hide resolved
Can you show us a demo of how it works? |
...in/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/killaura/ModuleKillAura.kt
Fixed
Show resolved
Hide resolved
Co-authored-by: DataModel <[email protected]>
Yeah add me on discord: alexdoth |
Please send the video clip here, if you have one. Is it for 1.8 or 1.9 combat? Because I have tried it for 1.9 combat and it did not really do what I thought it does. |
It's for 1.8 combat. The feature only extends the reach if the player is lagging or fake lagging. You can also disable this behavior by unchecking the "OnlyWhileLagging" option. In the video, I just set the range extension to 1 and enabled "OnlyWhileLagging". It's more like a legit feature since it only does something in a specific edge case where you are getting combos. I just added the chat messages in the video to demonstrates at which specific time it worked and not. It will be removed in future PRs. |
Velocity hit feature for KillAura.
The feature
This feature grants an extra hit if the player is lagging while receiving a combo from an opponent.