refactor(Spammer): improvement of custom format #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improved replacement
1zun4
reviewed
Dec 12, 2024
Comment on lines
+104
to
119
| private inline fun String.replace(oldValue: String, newValueProvider: () -> Any): String { | ||
| var index = 0 | ||
| val newString = StringBuilder(this) | ||
| while (true) { | ||
| index = newString.indexOf(oldValue, startIndex = index) | ||
| if (index == -1) { | ||
| break | ||
| } | ||
|
|
||
| val newValue = newValueProvider().toString() | ||
| newString.replace(index, index + oldValue.length, newValue) | ||
|
|
||
| index += newValue.length | ||
| } | ||
| return newString.toString() | ||
| } |
There was a problem hiding this comment.
What makes this better than the previous implementation?
There was a problem hiding this comment.
- For different keyword (
%d,%f, etc), one replacement will only create one StringBuilder, the previous one will create many strings. (one%dwill create 3 new strings) - The
indexOfnow will not search from the head, next search will start from the tail of previous one like:
example%ianother%iumm
^
search 1 start
example12345another%iumm
^
search 2 start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved replacement