Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ClickScheduler): smart toggle #4807

Open
wants to merge 5 commits into
base: nextgen
Choose a base branch
from

Conversation

larryngton2
Copy link
Contributor

only attacks when needed, might need refactoring

Copy link
Member

@1zun4 1zun4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing 'Smart'-toggle into Click Scheduler is bad. I don't think it fits here. It could also cause issues with other modules that rely on this click scheduler, but don't want to follow this smart practice. I think it should be merged, also what do you mean with 'Smart'? Is this 'Hit select' or what do you mean by that?

@larryngton2
Copy link
Contributor Author

Implementing 'Smart'-toggle into Click Scheduler is bad. I don't think it fits here. It could also cause issues with other modules that rely on this click scheduler, but don't want to follow this smart practice. I think it should be merged, also what do you mean with 'Smart'? Is this 'Hit select' or what do you mean by that?

with smart i mean it only clicks when needed, when you need to reduce, when your opponent it out of the hurttime and when you need to crit. but where else should i implement it then? i decided to implement it here since it modifies how clicks are handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants