Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HPC modules #20

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Fix HPC modules #20

merged 10 commits into from
Nov 25, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Nov 25, 2024

Changes

Select modules based on HPC & workflow language, and only load ccbrpipeliner if it is not already loaded

Issues

NA

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • [ ] Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.56%. Comparing base (20e241b) to head (48c9741).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/ccbr_tools/pipeline/hpc.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   29.92%   31.56%   +1.64%     
==========================================
  Files          17       17              
  Lines        1260     1264       +4     
==========================================
+ Hits          377      399      +22     
+ Misses        883      865      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kelly-sovacool kelly-sovacool merged commit c338de2 into main Nov 25, 2024
8 checks passed
@kelly-sovacool kelly-sovacool deleted the fix-modules branch November 25, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant