Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tools package #151

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Use tools package #151

merged 14 commits into from
Aug 26, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Aug 13, 2024

Changes

Refactor to use shared functions from https://github.com/CCBR/Tools

Issues

Related to CCBR/Tools#5

Equivalent PR in XAVIER: CCBR/XAVIER#105

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Update docs if there are any API changes.
  • [ ] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kopardev kopardev added the RENEE RepoName label Aug 13, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review August 13, 2024 21:17
error:
sys:1: ResourceWarning: unclosed <socket.socket fd=4, family=2, type=1, proto=0, laddr=(0.0.0.0, 0)>
ResourceWarning: Enable tracemalloc to get the object allocation traceback
@kelly-sovacool kelly-sovacool self-assigned this Aug 13, 2024
@kelly-sovacool
Copy link
Member Author

My test run completed successfully on the test dataset with hg38_45. @kopardev this is ready for your review.

@samarth8392 samarth8392 merged commit 5b9daeb into main Aug 26, 2024
5 checks passed
@samarth8392 samarth8392 deleted the use-tools-pkg branch August 26, 2024 16:25
@kelly-sovacool kelly-sovacool added this to the 2024-08 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RENEE RepoName
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants